Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Central Monitor #196

Merged
merged 28 commits into from
Nov 22, 2021
Merged

Port Central Monitor #196

merged 28 commits into from
Nov 22, 2021

Conversation

bruberu
Copy link
Member

@bruberu bruberu commented Oct 21, 2021

This particular PR presents a slightly modified form of the Central Monitor from Gregicality to add its functionality to CEu.

Most things are left unchanged, except for the removal of freedom-wrench-handling code.
Also, a minor issue with clipboards was fixed.

@Yefancy
Copy link
Member

Yefancy commented Oct 21, 2021

really nice. I reviewed your code roughly two days ago and it was basically good. But there are a lot of details, coremod, rendering and somthing else that I need to tweak. I will convert it into draft, and then open for review after I finish the modification.

@Yefancy Yefancy marked this pull request as draft October 21, 2021 01:27
@ALongStringOfNumbers
Copy link
Contributor

The various writeClientAction calls in this PR could be modified to use constants from GregtechDataValues for clarity. It would probably be easiest to define a new set of data codes though for all the central monitor stuff.

@Yefancy Yefancy marked this pull request as ready for review November 10, 2021 16:25
@Yefancy Yefancy merged commit b1e5363 into master Nov 22, 2021
@Yefancy Yefancy deleted the monitorCEu branch November 23, 2021 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants