Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix server crash with groovyscript multiblocks #1941

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

TechLord22
Copy link
Member

What

Fixes this the client-side only method getParticleTexture() being loaded on the server when GroovyScript classes extend RecipeMapMultiblockController. This is caused by the @SideOnly annotation not being inherited automatically for method overrides, as the super method does have correctly have the annotation.

Outcome

Fixes GregTechCEu/GregTech-Community-Pack#92.

@TechLord22 TechLord22 added the type: bug Something isn't working label Jul 13, 2023
@TechLord22 TechLord22 requested a review from a team as a code owner July 13, 2023 16:37
@serenibyss serenibyss merged commit 72d0539 into master Jul 13, 2023
@serenibyss serenibyss deleted the tc-fix-server-crash branch July 13, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash on server startup
3 participants