separate MarkerMaterial from OreDictUnifier #1933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ALongStringOfNumbers
approved these changes
Sep 6, 2023
serenibyss
pushed a commit
that referenced
this pull request
Oct 31, 2023
serenibyss
pushed a commit
that referenced
this pull request
Oct 31, 2023
serenibyss
pushed a commit
that referenced
this pull request
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Refactors MarkerMaterials into a new registry independent of
OreDictUnifier. This refactor also allows for multiple mods registering a MarkerMaterial with the same name, which would previously hard crash.Outcome
Separates
MarkerMaterialregistration fromOreDictUnifier.Potential Compatibility Issues
MarkerMaterials must now be created using
MarkerMaterial.create().Registration of MarkerMaterials is now automatic, and the methods to do so in OreDictUnifier have been removed.