Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OverlayedFluidHandler refactor #1694

Merged
merged 3 commits into from
Apr 10, 2023
Merged

OverlayedFluidHandler refactor #1694

merged 3 commits into from
Apr 10, 2023

Conversation

Tictim
Copy link
Contributor

@Tictim Tictim commented Apr 10, 2023

What

This PR refactors OverlayedFluidHandler. Supersedes #1682.

Implementation Details

In addition to the bugfix provided by aforementioned PR, this PR adds a few things.

  • Initialization of uniqueFluidMap cache was moved from initTank to usage.
  • Separated two insertion logic used to its own method.
  • allowSameFluidFill cache is replaced with direct access to overlayed.allowSameFluidFill() method.
  • Minor code edits (removing unnecessary getter/setters, docs and stuff)

Potential Compatibility Issues

None

@TechLord22 TechLord22 added the type: refactor Suggestion to refactor a section of code label Apr 10, 2023
@TechLord22 TechLord22 merged commit 456af17 into GregTechCEu:master Apr 10, 2023
@TechLord22 TechLord22 mentioned this pull request Apr 10, 2023
Closed
@Tictim Tictim deleted the overlayed_fluid_handler_refactor branch April 11, 2023 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TechLord22 TechLord22 TechLord22 approved these changes

Assignees
No one assigned
Labels
type: refactor Suggestion to refactor a section of code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tictim @TechLord22