Make stone types always show in TOP #1664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LAGIdiot
approved these changes
Apr 3, 2023
LAGIdiot
reviewed
Apr 3, 2023
There was a problem hiding this comment.
I looked through last changes and it still looks good.
Though as I mentioned on Discord it could be cool to know as what it will drop (in case it is not same as block itself). For example if you have Diorite Iron Ore, it could have tooltip which mentions it will drop as Iron Ore.
| return super.getSilkTouchDrop(state); | ||
| } | ||
| return super.getSilkTouchDrop(this.getDefaultState()); | ||
| public ItemStack getPickBlock(IBlockState state, RayTraceResult target, World world, BlockPos pos, EntityPlayer player) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Previously, when TOP tried to get the item for an ore block with a stone type that was meant to drop as the default stone type when mined, it would use the default
getPickBlockmethod which called thegetItemmethod, which prevented it from seeing its true stonetype. This was fixed by simply overridinggetPickBlock.Implementation Details
I just use the method that
getItem()used, which was its superclass's implementation, which I hope makes sense. Also, do I need the comment?Outcome
Always makes the correct stone type appear in TOP.
Additional Information
Potential Compatibility Issues
For any mods that add new stone types that are supposed to show the default stone type in TOP, this would prevent that, although I don't see why that would be intended.