Code

Refactor detector covers#1659

Code

Merged

TechLord22 merged 16 commits intomasterGregTechCEu/GregTech:masterfrom lagidiot-detector-cover-refactorGregTechCEu/GregTech:lagidiot-detector-cover-refactorCopy head branch name to clipboardApr 8, 2023

+293-512

Commits

Commits on Mar 29, 2023

• Add base class for detector covers

  LAGIdiot

  committed
  59b1eb3

  Copy full SHA for 59b1eb3

• Fix toggle not toggling

  LAGIdiot

  committed
  79c4531

  Copy full SHA for 79c4531

• Add screwdriver handling to CoverDetectorBase

  LAGIdiot

  committed
  5687572

  Copy full SHA for 5687572

• Call super on initialSyncData in CoverDetectorBase even though parent functions are empty

  LAGIdiot

  committed
  782e1c8

  Copy full SHA for 782e1c8

• Update Fluid Detector Covers to extend CoverDetectorBase

  LAGIdiot

  committed
  34218b4

  Copy full SHA for 34218b4

• Update Item Detector Covers to extend CoverDetectorBase

  LAGIdiot

  committed
  4d1a464

  Copy full SHA for 4d1a464

• Update Energy Detector Covers to extend CoverDetectorBase - with added compatibility check for inverted NBT key

  LAGIdiot

  committed
  585c9d2

  Copy full SHA for 585c9d2

• Update Activity Detector Covers to extend CoverDetectorBase

  LAGIdiot

  committed
  d7b9e24

  Copy full SHA for d7b9e24

• Rename detector cover for activity to follow naming system on rest of cover detectors

  LAGIdiot

  committed
  6709b19

  Copy full SHA for 6709b19

• Extract function to compute redstone from basic detector covers

  LAGIdiot

  committed
  d91072c

  Copy full SHA for d91072c

• Remove unused lang keys for detector messages

  LAGIdiot

  committed
  b38a15b

  Copy full SHA for b38a15b

• Update Advanced Activity detector to use utility function for calculating redstone signal strength

  LAGIdiot

  committed
  4559d14

  Copy full SHA for 4559d14

• Make toggle function in CoverDetectorBase private as it is not needed anywhere else

  LAGIdiot

  committed
  c2fc0f2

  Copy full SHA for c2fc0f2

• Clean up

  LAGIdiot

  committed
  33ca85c

  Copy full SHA for 33ca85c

Commits on Mar 31, 2023

• Move redstone logic related functions to own util file

  LAGIdiot

  committed
  2218e9e

  Copy full SHA for 2218e9e

Commits on Apr 5, 2023

• Add used network key for updating inverted on Detector covers to GregtechDataCodes

  LAGIdiot

  committed
  f7fc053

  Copy full SHA for f7fc053