Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update World Prospector App #1644

Merged
merged 5 commits into from
Mar 26, 2023
Merged

Update World Prospector App #1644

merged 5 commits into from
Mar 26, 2023

Conversation

Caedis
Copy link
Contributor

@Caedis Caedis commented Mar 24, 2023 •
edited
Loading

What

Updates the world prospector app with a couple of minor changes.

  • Fixes the battery drain when an AR app is "open", but is not in either hand
  • Highlight color is now based off the OreDictUnifier material if possible
  • Highlight color is now auto selected for JEI phantom drags
  • Clearing the block now also clears the highlight color
  • Rendering pauses when game is paused

Additional Information

Preview of changes
Discord link

Caedis added 2 commits March 24, 2023 09:16
@Caedis
Fix AR draining when not in either hand
47e26a3
@Caedis
Update World Prospector App
ecff2d4 
Colors are pulled from block materials if available
Fixed JEI phantom dragging (didnt update color mainly)
TechLord22
TechLord22 reviewed Mar 24, 2023
View reviewed changes
src/main/java/gregtech/common/terminal/app/worldprospector/WorldProspectorARApp.java Outdated Show resolved Hide resolved
src/main/java/gregtech/common/terminal/app/worldprospector/WorldProspectorARApp.java Outdated Show resolved Hide resolved
src/main/java/gregtech/common/terminal/app/worldprospector/WorldProspectorARApp.java Outdated Show resolved Hide resolved
src/main/java/gregtech/common/terminal/app/worldprospector/WorldProspectorARApp.java Show resolved Hide resolved
src/main/java/gregtech/common/terminal/app/worldprospector/WorldProspectorARApp.java Outdated Show resolved Hide resolved
src/main/java/gregtech/common/items/behaviors/TerminalBehaviour.java Outdated Show resolved Hide resolved
src/main/java/gregtech/common/terminal/app/worldprospector/WorldProspectorARApp.java Outdated Show resolved Hide resolved
@TechLord22 TechLord22 added the type: bug Something isn't working label Mar 24, 2023
@Caedis Caedis force-pushed the fix-world-prospector branch from d61749f to 07a1cb9 Compare March 25, 2023 05:11
@TechLord22 TechLord22 added this to the 2.5.5 milestone Mar 25, 2023
@TechLord22 TechLord22 merged commit 2e05ea2 into GregTechCEu:master Mar 26, 2023
@Caedis Caedis deleted the fix-world-prospector branch March 27, 2023 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TechLord22 TechLord22 TechLord22 approved these changes

Assignees
No one assigned
Labels
type: bug Something isn't working
Projects
None yet
Milestone
2.6
Development

Successfully merging this pull request may close these issues.
2 participants
@Caedis @TechLord22