Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR removes the CT Ingredient Wrapper for recipes, instead converting the provided
CTRecipeBuilder
input directly toGTRecipeInput
s. This will prevent future bugs with CT-specific behavior we would otherwise be unaware of, and also defines the behavior of all input scenarios CT can provide. This will us to choose which configurations we support.As of this PR, items used in recipes with NBT will match any items that contain all of the recipe's NBT. As long as the sample completely overlaps with the recipe, matching will succeed. More complex matching can be achieved with GroovyScript instead, if desired.
For inputs representing multiple items, typically produced using CT's
|
operator, the NBT for each stack ORed together will be matched for exclusively the stack it applies to. See the validation section for details.Validation
Using the following script, simple validation of this behavior can be performed.
Renaming dirt in the anvil to
MyName
will allow testing this the easiest, leaving only one input line uncommented for each of the following scenarios:/give @p minecraft:dirt 64 0 {display: {Name: "MyName"}}
and/give @p minecraft:stone 64 0 {RepairCost: 0}
. Both of the stacks for the third case match one of the valid input ingredients.Outcome
Removes the CT Ingredient Wrapper to prevent undefined behavior. Supersedes #1604, and also fixes #1600.
Potential Compatibility Issues
No compatibility issues are expected other than those outlined above, which are now considered invalid input configurations.