Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add Concrete movement speed bonuses #1593

Merged
merged 5 commits into from
Mar 16, 2023
Merged

Re-add Concrete movement speed bonuses #1593

merged 5 commits into from
Mar 16, 2023

Conversation

ALongStringOfNumbers
Copy link
Contributor

What

Adds back the movement speed bonuses for concrete. These were removed in #419 (I think accidentally), when Tech divided up the concrete block class

Outcome

Once again move faster on concrete

@ALongStringOfNumbers ALongStringOfNumbers added the type: bug Something isn't working label Mar 12, 2023
@TechLord22 TechLord22 added this to the 2.5.5 milestone Mar 13, 2023
TechLord22
TechLord22 reviewed Mar 13, 2023
View reviewed changes
Copy link
Member

@TechLord22 TechLord22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current implementation works, but in the future we ought to consider a better way of managing all these block variants to favor much more code re-use, as it is very cumbersome and duplicate-heavy right now.

src/main/java/gregtech/api/block/VariantBlock.java Show resolved Hide resolved
src/main/java/gregtech/common/blocks/BlockAsphalt.java Outdated Show resolved Hide resolved
@TechLord22 TechLord22 merged commit 37a8bbb into master Mar 16, 2023
@TechLord22 TechLord22 deleted the alson-concrete-speed branch March 16, 2023 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TechLord22 TechLord22 TechLord22 approved these changes

Assignees
No one assigned
Labels
type: bug Something isn't working
Projects
None yet
Milestone
2.6
Development

Successfully merging this pull request may close these issues.
2 participants
@ALongStringOfNumbers @TechLord22