Fix issues with breaking ice #1587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I cannot reproduce the issue of ice never creating water when broken with an empty hand. So I am not sure if the empty check is needed at all.
But the other fix works correctly, and a check to empty won't hurt anything. At this point, do we still even need to use the task scheduler?
Tictim
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR fixes two issues with breaking ice.
First, it checks if the tool ItemStack is empty. Doing so prevents the ice breaking code from applying when mining with things other than tools. This previously caused ice to never create water when broken with an empty hand, for example.
Second, it fixes the "looping water" bug, where flowing water moving into the blockspace would get repeatedly deleted, after the initial ice block's water was removed.
Outcome
Fixes bugs with breaking ice.