Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ghost Circuits #1458

Merged
merged 12 commits into from
Mar 19, 2023
Merged

Ghost Circuits #1458

merged 12 commits into from
Mar 19, 2023

Conversation

Caedis
Copy link
Contributor

@Caedis Caedis commented Jan 29, 2023 •
edited
Loading

What

Implement ghost circuits from gt5u

Todo

  • Update tooltips
  • Open config gui on shift left click (deferring until MUI rework)

Potential Compatibility Issues

Anything in the circuit slot prior to updating will be consumed and the ghost circuit will have the same config value if it had one.

@Caedis Caedis changed the title Ghost ICs Ghost Circuits Jan 29, 2023
@Caedis Caedis marked this pull request as ready for review February 2, 2023 21:39
@Quarri6343 Quarri6343 added the type: feature New feature or request label Feb 4, 2023
LAGIdiot
LAGIdiot requested changes Feb 12, 2023
View reviewed changes
Copy link
Contributor

@LAGIdiot LAGIdiot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation is mostly reasonable (some comments). In game test did not found any serious problems (small put in comment). Upgrade behavior is as described.

src/main/java/gregtech/api/gui/widgets/GhostCircuitSlotWidget.java Outdated Show resolved Hide resolved
src/main/java/gregtech/api/gui/widgets/GhostCircuitSlotWidget.java Outdated Show resolved Hide resolved
src/main/java/gregtech/api/metatileentity/SimpleMachineMetaTileEntity.java Outdated Show resolved Hide resolved
@Caedis Caedis force-pushed the feat-ghost-circuits branch from 496185e to fbaf14c Compare February 12, 2023 16:46
@Caedis Caedis requested a review from LAGIdiot February 12, 2023 16:48
LAGIdiot
LAGIdiot approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@LAGIdiot LAGIdiot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finishing this PR! Approved.

This is probably the best thing we can get without getting modular UI and totally reworking GUI for this.

@PrototypeTrousers PrototypeTrousers merged commit ea896f2 into GregTechCEu:master Mar 19, 2023
@Tictim Tictim mentioned this pull request Mar 20, 2023
Merged
MrKono added a commit to MrKono/GregTech that referenced this pull request Mar 20, 2023
@MrKono
[apply] GregTechCEu#1610 & GregTechCEu#1458
1a965b1
@Caedis Caedis deleted the feat-ghost-circuits branch March 25, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LAGIdiot LAGIdiot LAGIdiot approved these changes

Assignees
No one assigned
Labels
type: feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Caedis @LAGIdiot @PrototypeTrousers @Quarri6343