Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhauling & updating zh_cn.lang #1309

Merged
merged 13 commits into from
Mar 9, 2023
Merged

Conversation

ChromaPIE
Copy link
Contributor

@ChromaPIE ChromaPIE commented Nov 29, 2022

What

Just realized that I've been in a break from the zh_cn support role on Discord for too long, time to wake up.

It was supposed to be a perma-farewell to the community but I'll be sleepless in a drastic suffer watching people, care or don't, playing with such a mad ruined localization.

TL;DR: The localization was sucked and outdated, with some Google or whatever translated content and goofy ahh expressions, so I gave it an overhaul and update.

Things worth mentioning:

  • It doesn't heavily depend on the existing one, actually it has long been branched from the one for an early version, and kept maintained for personal use, so expect huge differences, but better believe that every single change is from a veteran, for the better. So I want to apologize for not being able to give every changes a reason. For me it's not even an overhaul, it's nothing but an update for the previous one that I've been using, thus I'm afraid I can't respond to the questions like The original ones are good enough for what did you change them?
  • I didn't make change to those nonsense translated terms that until now there's still no annotation for the origin of them, like Naquadah as silica rock. This overhaul is already enough to make a micro group of ppl mad (those oldschool elders don't even seem to play the mod), Ion wanna escalate it.
  • Always hit me on Discord. Leaving all stuff here will make this page one hunnid miles long.
  • If this got merged, I may continue working on future updates, keeping it high quality as possible and keeping the edge bleeding.

Implementation Details

I know there be native speakers among the team. A review throughout the whole file for possible typos or stuff won't be too nice, only if they ain't one of the oldschool elders. If so just close it, let people end up seeing how Filters was translated to 滤镜 (also filters, but for Tik Tok and Snapchat).

Outcome

  • Average players having a rather decent experience playing the mod with a readable localization.
  • Some ex-contributors with nice ego or ones we don't even know coming from nowhere being malding for any single changes asking you to call the manager. I don't want no drama, so if it turns out to be a thing, close it.

@ALongStringOfNumbers ALongStringOfNumbers added the type: translation The issue or pull request concerns translation label Nov 30, 2022
@ChromaPIE
Copy link
Contributor Author

Completely unnecessary translation changes.

🤓 comment. If you even refuse to read the brief Implementation Details part just quit leaving any nonsense here. So cringe

@Oganesson897
Copy link

Completely unnecessary translation changes.

🤓 comment. If you even refuse to read the brief Implementation Details part just quit leaving any nonsense here. So cringe

Ignore me.

Copy link
Contributor

@iFuckShit iFuckShit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just browsed around. Nice work, getting those wrong & machine-translationese off

src/main/resources/assets/gregtech/lang/zh_cn.lang Outdated Show resolved Hide resolved
src/main/resources/assets/gregtech/lang/zh_cn.lang Outdated Show resolved Hide resolved
src/main/resources/assets/gregtech/lang/zh_cn.lang Outdated Show resolved Hide resolved
src/main/resources/assets/gregtech/lang/zh_cn.lang Outdated Show resolved Hide resolved
src/main/resources/assets/gregtech/lang/zh_cn.lang Outdated Show resolved Hide resolved
ChromaPIE and others added 4 commits February 2, 2023 01:43
工具这块后来大改过,key都改了,需要重整,diff慢慢看

Co-authored-by: iFuckShit <[email protected]>
@ChromaPIE
Copy link
Contributor Author

@Quarri6343 All set for merging.

@TechLord22 TechLord22 merged commit 4572ef4 into GregTechCEu:master Mar 9, 2023
@ChromaPIE
Copy link
Contributor Author

jesus why i got merged in front of my eyes. i literally just opened the page

@TechLord22 TechLord22 mentioned this pull request Mar 9, 2023
Copy link
Contributor

@iouter iouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

总体还行,但是一些东西并不需要改

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: translation The issue or pull request concerns translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants