Add a "Reverse" command to the "Order" menu #2273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Keavon
approved these changes
Feb 11, 2025
There was a problem hiding this comment.
Works like a charm, thanks. Your code didn't compile for some reason (maybe you pushed a slightly outdated version?) but I fixed that by changing some mut keywords. I also cleaned up a lot of cargo fmt and cargo clippy issues, and then did a review for code style (things like starting comments with a capital letter and a space after the //). And I fixed a logic bug with the undo/redo history. Feel free to look over my diff for learning purposes. Thanks for this valuable contribution! Let me know if you need help finding the next issue to work on.
|
Thanks! I'll do better next time. |
|
You're all good, this is in the range of ordinary code review tweaks, especially for a first time contribution. Welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2271
If multiple noncontiguous ranges are present with the same direct parent (they're siblings in the nesting hierarchy), all the selected items should be swapped as part of the same list: [1], [2], 3, 4, [5], [6] should become [6], [5], 3, 4, [2], [1] (where [] indicates selection).
If any selected layer has a selected ancestor, only the ancestor is considered selected and all children/descendants are ignored as part of the selection.