Add transform cage to textbox while using Text tool #2176
Conversation
Keavon
force-pushed
the
master
branch
2 times, most recently
from
7465fad to
ab724d8
Compare
|
Hi, just checking on what the status of this is. It's possible I've forgotten that you might be waiting on something from me, and if so, please remind me. |
|
Right now the cursor behavior doesn't work quite right, upon clicking a transform handle it transforms back to the text cursor Also the performance declined significantly after I added the function to check if lines are being clipped by max_height |
There was a problem hiding this comment.
The function for line_clipping has practically the same code running as the bounding_box function and I assume it's an intensive function which is what causes the lag when running it. I would guess the best way is to ditch this line_clipping function and store the value for line clipping in another variable in the bounding_box function but I am not sure where to introduce that variable.
There was a problem hiding this comment.
All the pivot and multi-layer transformation related code is commented out here. Besides that, the hints are yet to be added.
editor/src/messages/portfolio/document/utility_types/network_interface.rs
Show resolved
Hide resolved
There was a problem hiding this comment.
This is a function that updates pivot for any input value for the normalized pivot instead of calculating it from transform. pretty similar code to the recalculate_pivot function above, implementing the transformation cage for the text tool felt awkward, I feel like I could refactor a lot of code here and there. Some direction would help in that.
|
!build |
|
|
I think updating this branch with master caused some breakages to the Text tool resizing cage. Can you please take a look? Also from a code review perspective, there seems to be a lot of leftover commented out lines that should be removed or dealt with before landing the PR. I don't have the mental bandwidth right now to dig into your concerns you left in your code review above but maybe after letting this sit for a number of days, you can come back to it with some fresh ideas to answer those for yourself. Message me on Discord if are blocked by anything you definitely need answers to. Thanks. |
Part of #1105
Follow up to #2118