Restore the Imaginate node with the full node graph architecture (but a flaky deadlock remains) #1908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrueDoctor
force-pushed
the
fix-imaginate-v2
branch
from
f5834e6 to
431df48
Compare
TrueDoctor
force-pushed
the
fix-imaginate-v2
branch
from
e817e73 to
d50959c
Compare
Keavon
force-pushed
the
fix-imaginate-v2
branch
from
d50959c to
9c56936
Compare
Keavon
changed the title
Keavon
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Hopefully, as soon as possible, we can fix the deadlock issue, then I can polish up the remaining features and add more server backends once you're able to help fix the freeze. But it makes sense to merge this now. Thanks for helping me to revive this much-delayed and important feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly resolves #1511