Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add onOperationComplete & onOperationError callbacks #2

Merged
merged 3 commits into from
Jul 23, 2022
Merged

feat: add onOperationComplete & onOperationError callbacks #2

merged 3 commits into from
Jul 23, 2022

Conversation

GNMoseke
Copy link
Contributor

Adds an onStop callback & registration function for configuring behavior when the server receives a GQL_STOP message

@GNMoseke
Copy link
Contributor Author

@NeedleInAJayStack This should allow for unsubscribe handling

@GNMoseke GNMoseke changed the title fix: expose onStop callback handler feat: add onOperationComplete & onOperationError callbacks Jul 22, 2022
NeedleInAJayStack
NeedleInAJayStack approved these changes Jul 23, 2022
View reviewed changes
Copy link
Member

@NeedleInAJayStack NeedleInAJayStack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks @GNMoseke!

@NeedleInAJayStack NeedleInAJayStack merged commit 72be825 into GraphQLSwift:main Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeedleInAJayStack NeedleInAJayStack NeedleInAJayStack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GNMoseke @NeedleInAJayStack