-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export gProfiler-needed functionality from asprof #7
Export gProfiler-needed functionality from asprof #7
Conversation
4938ce8
to
044a094
Compare
@marcin-ol I pushed the rebase to async-profiler-granulate, I'm not sure the rebase is perfect - will validate it later - meanwhile you can re-base your branch on it and add your commits? |
d0cad8b
to
6e66b65
Compare
044a094
to
1f31fdc
Compare
@marcin-ol , I fixed the rebase again so please re-apply the 2 commits of yours. Now it's ready from my end. This is the full range-diff of the rebase for reference.
What's gone as part of this rebase is Other than that change, other parts should be alright and I trust our tests. |
- make sure fdtransfer parent process finishes, - support prefix directory for async-profiler sharedlib
6e66b65
to
a0205eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done reviewing
…nd startup on musl-based systems
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did another review round. Left a bunch of small comments. Also, I re-reviewed my rebase. All looks good! Let's finish those and merge it :)
In AP 3.0, @Jongy edited this commit to export fdtransfer from asprof, as jattach and jcmd were added in async-profiler@b8a60e6 to upstream.
In AP 3.0, @Jongy edited this commit to export fdtransfer from asprof, as jattach and jcmd were added in async-profiler@b8a60e6 to upstream.
In AP 3.0, @Jongy edited this commit to export fdtransfer from asprof, as jattach and jcmd were added in async-profiler@b8a60e6 to upstream.
Experimental merge of upstream changes to async-profiler.
Implement changes necessary to support upcoming features (esp. binary launcher - asprof) in gprofiler.
This is approach 1 - adding jattach passthru in asprof launcher.