Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added auto "stack all" to all chests in range #75

Merged

Conversation

Bellian
Copy link

@Bellian Bellian commented May 25, 2024

This feature will perform the "Stack all" function on all chests in range.
This will automaticaly sort all items from the player inventory into chests in range.

Works with the "stack all" button in inventory as well as holding the "E" button.

Also adds a feature to disable equipment to be placed in chests using the "Stack all" feature.
So you keep your hammer in inventory if another hammer is inside of a chest.

@Bellian Bellian marked this pull request as draft May 25, 2024 13:05
@Bellian Bellian marked this pull request as ready for review May 25, 2024 13:07
@Bellian
Copy link
Author

Bellian commented May 25, 2024

Don't know for sure how to test this for multiplayer. Pretty new to this.
Any advice here @Grantapher?

@Grantapher
Copy link
Owner

I believe you can open the game multiple times on the same computer, but you will need to set up a dedicated server as well (which can also likely be done on the same computer).

@Bellian
Copy link
Author

Bellian commented May 26, 2024

Nope, just got me banned from this server XD
Will test tomorrow with someone else.

@Bellian
Copy link
Author

Bellian commented May 26, 2024

Works in multiplayer. Will also prevent auto sorting in chests if they are opened by anyone else. Guess this is intended since inventories are exclusively blocked if opened to prevent sideeffects.

But it will show a message. Should i see if i can remove this message?

Copy link
Owner

@Grantapher Grantapher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, just one more organizational change and I think it will be good!

@Bellian
Copy link
Author

Bellian commented May 27, 2024

changed and tested

@Grantapher Grantapher merged commit 5489eab into Grantapher:grantapher-development May 27, 2024
@VulcanTourist
Copy link

VulcanTourist commented Oct 10, 2024

This feature now needs to be (self-)documented! The description in the CFG is inadequate to explain what it does in an unambiguous fashion. Does it simply blindly populate the closest containers in range with anything and everything, or is it selective and only stores items that are already represented by a stack in the container? Also, the means of activation must be described, and ideally the hotkey should be made configurable; other mods might employ the same long-pressed hotkey.

@Grantapher
Copy link
Owner

Set to true to automatically perform the "Stack All" action on all chests in range.

What problem do you have with this? If you have a better description then feel free to send a pr.

@VulcanTourist
Copy link

VulcanTourist commented Oct 10, 2024

What problem do you have with this? If you have a better description then feel free to send a pr.

I already explained one potential ambiguity above. I don't think I can give a better single example of how it's ambiguous. You know exactly how it works, and must communicate the nuance of it to others without that intimate knowledge.

It also says "automatically" in the CFG, but again someone is presuming that users have the inherent knowledge of the developer. Exactly what is automatic? In the discussions here it seems like there is supposed to be an extra UI button somewhere and/or an extended keypress to activate it - meaning that it's not truly automatic - and neither of which are mentioned in relation to "automatic". In the first post here "sorting" is mentioned, implying something more intelligent than mere blind transfer to available storage, but again that isn't mentioned in the CFG or anywhere else. If indeed it's "sorting", what are the criteria for that?

I tried enabling the feature tonight, and it caused nothing at all to happen with player inventory while in range, neither without intervention nor by long-pressing the interaction ([E]) key. If it's truly expected to be fully automatic, then it's not working as intended for me. If indeed it's supposed to be fully automatic, how then does one keep items in inventory that are wanted to remain there? How is it prevented from repeatedly grabbing the same items from inventory when they are placed there within range of containers?

That is aside from the documentation issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants