Feature analytics #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
arthurspa
reviewed
Nov 13, 2020
| print("Report saved as " + filename) | ||
|
|
||
| def load_sessions(self): | ||
| path = self.username + "/sessions.json" |
There was a problem hiding this comment.
We should provide an API for fetching the path for the session. The way it is right now makes it difficult to refactor.
Perhaps we can improve this. This kind of information should be fetched from the core.
| return None | ||
|
|
||
| def plot_followers_growth(self, sessions, pdf, username, period): | ||
| followers_count = [int(session["profile"]["followers"]) for session in sessions] |
There was a problem hiding this comment.
Same here. If we make session to be a class with all attributes, it improves maintainability of the code.
session.profile.followers instead. Can you please create a task to improve this? We can merge it like this for now..
arthurspa
approved these changes
Nov 13, 2020
mastrolube
approved these changes
Nov 13, 2020
|
Yeah; this was basically just a copy/paste from the original PR. We can improve it - I just wanted to get it in since we’ve had the PR open for over a week and “it works”. 😄 Will add to project board. |
philip-ulrich
added a commit
that referenced
this pull request
Nov 13, 2020
* No one is maintaining these - removing (#33) - These likely need re-written from scratch anyway - removing resources we don't use like patreon or the insomniac logo * Feature analytics (#31) * increment version * fixing bug with interact argument * ignoring all .pdf files * Adding tool to generate PDF reports with statistics using matplotlib * blackening Co-authored-by: narkopolo <[email protected]> Co-authored-by: narkopolo <[email protected]>
philip-ulrich
added a commit
that referenced
this pull request
Nov 13, 2020
* No one is maintaining these - removing (#33) - These likely need re-written from scratch anyway - removing resources we don't use like patreon or the insomniac logo * Feature analytics (#31) * increment version * fixing bug with interact argument * ignoring all .pdf files * Adding tool to generate PDF reports with statistics using matplotlib * blackening Co-authored-by: narkopolo <[email protected]> * Adding missing dependency (#37) * No one is maintaining these - removing - These likely need re-written from scratch anyway - removing resources we don't use like patreon or the insomniac logo * adding matplotlib dependency Co-authored-by: narkopolo <[email protected]>
philip-ulrich
added a commit
that referenced
this pull request
Nov 14, 2020
* No one is maintaining these - removing - These likely need re-written from scratch anyway - removing resources we don't use like patreon or the insomniac logo * No one is maintaining these - removing (#33) - These likely need re-written from scratch anyway - removing resources we don't use like patreon or the insomniac logo * Feature analytics (#31) * increment version * fixing bug with interact argument * ignoring all .pdf files * Adding tool to generate PDF reports with statistics using matplotlib * blackening Co-authored-by: narkopolo <[email protected]> * Adding missing dependency (#37) * No one is maintaining these - removing - These likely need re-written from scratch anyway - removing resources we don't use like patreon or the insomniac logo * adding matplotlib dependency * Use python logging module (#36) * Use python logging module - add log.py: used to configure python logging module There are two log handlers: one colored for the console and one with raw data for the crash report. This way we will be able to make the console be less cluttered while still have debug information when a crash happens. * Change plugin loading log level to INFO * Remove unused log constants (#41) * Remove pipenv because they can't figure out how to support python version ranges pypa/pipenv#1050 (#44) * No one is maintaining these - removing - These likely need re-written from scratch anyway - removing resources we don't use like patreon or the insomniac logo * removing pipenv * removing extra res folder - updating version Co-authored-by: narkopolo <[email protected]> Co-authored-by: Arthur Silva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaces #19 since the rebase completely screwed it up.
"Adding tool to generate PDF reports with statistics using matplotlib"