Update ESLint config #1068
Merged
Update ESLint config #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use ESLint’s recommend ruleset - Make config more explicit - Do not blindly use wordpress/recommended ESLint ruleset. Makes it easier to extract / split out later.
swissspidy
added
the
Type: Infrastructure
swissspidy
requested review from
barklund,
BrittanyIRL,
carloskelly13,
dvoytenko,
mariano-formidable,
pbakaus and
spacedmonkey
as code owners
|
Size Change: -63 B (0%) Total Size: 871 kB
ℹ️ View Unchanged
|
barklund
reviewed
Apr 6, 2020
assets/src/edit-story/components/colorPicker/test/useColor/removeCurrentStop.js
Show resolved
Hide resolved
carloskelly13
approved these changes
Apr 6, 2020
dvoytenko
approved these changes
Apr 15, 2020
| @@ -47,6 +47,7 @@ function EditElement({ element }) { | |||
| actions: { getBox }, | |||
| } = useUnits(); | |||
|
|
|||
| //eslint-disable-next-line @wordpress/no-unused-vars-before-return | |||
There was a problem hiding this comment.
I'm wondering why doesn't it know about the usage? Does it not expand JSX before running these rules?
There was a problem hiding this comment.
WordPress/gutenberg#21358 has a pending fix with details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@wordpress/eslint-plugin/recommendedESLint ruleset. Makes it easier to extract / split out later.@wordpress/eslint-plugin@wordpress/eslint-plugin/i18nruleset and fix issues