Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade all bundled tools in the Skaffold container #9646

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

plumpy
Copy link
Collaborator

@plumpy plumpy commented Jan 10, 2025

No description provided.

@plumpy plumpy requested a review from Darien-Lin January 10, 2025 21:06
@plumpy plumpy requested a review from a team as a code owner January 10, 2025 21:06
Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @plumpy and reviewers,

I'm currently reviewing this pull request and will provide my feedback in a few minutes. In the meantime, I'm giving you a summary of the pull request's content to help you and other reviewers quickly understand the changes and intent.

This pull request, "chore: upgrade all bundled tools in the Skaffold container", aims to update all the bundled tools within the Skaffold container to their latest versions. I've analyzed the changes and found the following:

  • Base Image Upgrade: The base Alpine image has been upgraded from alpine:3.10 to alpine:3.21.2 across all tool download stages.
  • Tool Version Updates: Several tools have received version bumps:
    • kubectl: v1.27.2 -> v1.32.0
    • helm: v3.12.0 -> v3.16.4
    • kustomize: 5.0.3 -> 5.5.0
    • kpt: 1.0.0-beta.33 -> 1.0.0-beta.55
    • kompose: v1.26.0 -> v1.35.0
    • container-structure-test: v1.10.0 -> v1.19.3
    • kind: v0.11.1 -> v0.26.0
    • k3d: v5.0.3 -> v5.7.5
    • gcloud: 496.0.0 -> 505.0.0
    • bazel: 4.2.1 -> 8.0.0
  • SHA Updates: All SHA256 and SHA512 checksums have been updated to reflect the new tool versions. The change from SHA512 to SHA256 for some tools is also noted.

The changes primarily affect deploy/skaffold/Dockerfile.deps and the corresponding SHA checksum files in the deploy/skaffold/digests directory. Specific line changes are too numerous to list here, but the diff clearly shows the updated versions and checksums.

I'll be looking for any potential compatibility issues introduced by these updates during my full review.

Here's a little poem to brighten your day:

New tools, shiny and bright,
Skaffold's container takes flight,
Updates all around,
Smooth sailing is found.

Best,
Gemini/code-review-assist

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR upgrades various bundled tools within the Skaffold container. The updates are generally good and bring Skaffold up to date with newer versions of these tools. Ensuring these tools are up-to-date is important for security and functionality. A few minor suggestions follow.

@plumpy plumpy merged commit fb14be6 into GoogleContainerTools:main Jan 13, 2025
14 checks passed
@plumpy plumpy deleted the upgrade_container_tools branch January 13, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants