fix(lookupRemote): fixed lookup.go lookupRemote to compare remote and cached digests #9278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idsulik
force-pushed
the
fix-issue-9248
branch
from
8eb8b81 to
2a1d1da
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #9278 +/- ##
==========================================
- Coverage 70.48% 63.56% -6.92%
==========================================
Files 515 634 +119
Lines 23150 32717 +9567
==========================================
+ Hits 16317 20798 +4481
- Misses 5776 10316 +4540
- Partials 1057 1603 +546 ☔ View full report in Codecov by Sentry. |
ericzzzzzzz
approved these changes
Jan 31, 2024
|
Do you plan a patch release? |
ericzzzzzzz
pushed a commit
to ericzzzzzzz/skaffold
that referenced
this pull request
Feb 7, 2024
… cached digests (GoogleContainerTools#9278) * fix(lookupRemote): fixed lookup.go lookupRemote to compare remote and cached digests * fixes * fixed lookup.go * fixes
|
#9301 to patch on 2.10 |
ericzzzzzzz
added a commit
that referenced
this pull request
Feb 7, 2024
* fix(lookupRemote): fixed lookup.go lookupRemote to compare remote and cached digests (#9278) * fix(lookupRemote): fixed lookup.go lookupRemote to compare remote and cached digests * fixes * fixed lookup.go * fixes * feat: schema * lint --------- Co-authored-by: idsulik <[email protected]>
|
I still see this issue in 2.10.1 |
|
Yes, sorry, I fixed it here #9306 , waiting for merge |
ericzzzzzzz
added a commit
to ericzzzzzzz/skaffold
that referenced
this pull request
Feb 15, 2024
…mote and cached digests (GoogleContainerTools#9278)" This reverts commit 9ff4546.
ericzzzzzzz
added a commit
that referenced
this pull request
Feb 15, 2024
* Revert "fix(lookupRemote): fixed lookup.go lookupRemote to compare remote and cached digests (#9278)" This reverts commit 9ff4546. * Revert "fix: Scope Issue with the 'entry' variable when looking up remote images and tests additions (#9211)" This reverts commit ffe769c. * Revert "fix: puling images when working with a remote repository (#9177) (#9181)" This reverts commit 9376dc0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9248
Description
It is used to lookup remote images by tag and overwrite a cached item even if the digests are different, now it compares the digests