Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement skaffold delete for docker deployer using docker labels #8885

Merged
merged 4 commits into from
Jun 26, 2023

Conversation

renzodavid9
Copy link
Contributor

@renzodavid9 renzodavid9 commented Jun 15, 2023

Fixes: #6314

Description
This PRs enables the skaffold delete command when using the Docker deployer. The logic is based in the use of Docker labels to tag the different resources created during deployment with the Docker deployer.

During a deployment different resources can be created by Skaffold: containers (skaffold.yaml containers and debug containers), networks, volumes (when doing skaffold debug). The logic deletes the resources associated with the project where the command is running.

@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #8885 (f40bf71) into main (290280e) will decrease coverage by 6.88%.
The diff coverage is 48.99%.

@@            Coverage Diff             @@
##             main    #8885      +/-   ##
==========================================
- Coverage   70.48%   63.60%   -6.88%     
==========================================
  Files         515      622     +107     
  Lines       23150    31676    +8526     
==========================================
+ Hits        16317    20148    +3831     
- Misses       5776    10017    +4241     
- Partials     1057     1511     +454     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 40 more

... and 413 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@renzodavid9 renzodavid9 added the kokoro:force-run forces a kokoro re-run on a PR label Jun 16, 2023
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Jun 16, 2023
@renzodavid9 renzodavid9 added the kokoro:force-run forces a kokoro re-run on a PR label Jun 16, 2023
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Jun 16, 2023
@renzodavid9 renzodavid9 marked this pull request as ready for review June 16, 2023 17:41
@renzodavid9 renzodavid9 merged commit 29ae963 into GoogleContainerTools:main Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement skaffold delete for Docker deployer
3 participants