Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: logic to only emit the tags related with verify on skaffold verify #8851

Merged
merged 2 commits into from
Jun 6, 2023

Conversation

renzodavid9
Copy link
Contributor

Fixes: #8671

Description
This PR adds the logic to only output the artifacts tags related with verify when running skaffold verify instead of printing all the artifacts detected in the given --build-artifacts=build.json file.

@renzodavid9 renzodavid9 changed the title Issue 8671 feat: logic to only emit the tags related with verify on skaffold verify Jun 5, 2023
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #8851 (7c05f58) into main (290280e) will decrease coverage by 6.58%.
The diff coverage is 48.99%.

@@            Coverage Diff             @@
##             main    #8851      +/-   ##
==========================================
- Coverage   70.48%   63.90%   -6.58%     
==========================================
  Files         515      620     +105     
  Lines       23150    31471    +8321     
==========================================
+ Hits        16317    20113    +3796     
- Misses       5776     9852    +4076     
- Partials     1057     1506     +449     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 40 more

... and 410 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@renzodavid9 renzodavid9 added the kokoro:force-run forces a kokoro re-run on a PR label Jun 6, 2023
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Jun 6, 2023
@renzodavid9 renzodavid9 marked this pull request as ready for review June 6, 2023 14:29
@renzodavid9 renzodavid9 requested review from plumpy and ericzzzzzzz June 6, 2023 14:29
@renzodavid9 renzodavid9 merged commit 811c07e into GoogleContainerTools:main Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

skaffold verify should only emit tag values for verify images (not all artifacts)
3 participants