fix: conditionally drain docker logs on stop to avoid docker deployer to stay in infinite loop #8838
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8819
Description
This PR is to fix the Docker deployer that stays in an infinite loop when doing
skaffold dev
. The main reason behind this is the Docker logger trying to drain the logs from running containers when doing logger stop (stop is executed before remove). The docker logs drain is needed for verify and custom actions, so we are adding a new conditional flag to disable the option forskaffold dev
.