-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: increase progressDeadlineSeconds timeout for TestRunUnstableChecked #8833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #8833 +/- ##
==========================================
- Coverage 70.48% 63.95% -6.53%
==========================================
Files 515 620 +105
Lines 23150 31455 +8305
==========================================
+ Hits 16317 20118 +3801
- Misses 5776 9833 +4057
- Partials 1057 1504 +447
... and 409 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
renzodavid9
changed the title
test: fix TestRunUnstableChecked
test: increase progressDeadlineSeconds timeout for TestRunUnstableChecked
May 29, 2023
plumpy
approved these changes
May 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
renzodavid9
added a commit
to renzodavid9/skaffold
that referenced
this pull request
May 31, 2023
…eChecked pass (GoogleContainerTools#8833) (cherry picked from commit ebda959)
renzodavid9
added a commit
to renzodavid9/skaffold
that referenced
this pull request
May 31, 2023
…eChecked pass (GoogleContainerTools#8833) (cherry picked from commit ebda959)
renzodavid9
added a commit
to renzodavid9/skaffold
that referenced
this pull request
May 31, 2023
…eChecked pass (GoogleContainerTools#8833) (cherry picked from commit ebda959)
renzodavid9
added a commit
to renzodavid9/skaffold
that referenced
this pull request
Jun 3, 2023
…eChecked pass (GoogleContainerTools#8833) (cherry picked from commit ebda959)
renzodavid9
added a commit
to renzodavid9/skaffold
that referenced
this pull request
Jun 9, 2023
…eChecked pass (GoogleContainerTools#8833) (cherry picked from commit ebda959)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #8822
Description
The TestRunUnstableChecked integration test is failing due to it reaches the deadline specified in
Deployment.spec.progressDeadlineSeconds
before reaching the expected error in the test; theDeployment.spec.progressDeadlineSeconds
is used to configure the status check timeout. This PR increase the deadline.Follow-up Work
Add the change in the different LTS branches