Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add minikube tunnel command in the tutorial #8490

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

dapeleg-dn
Copy link
Contributor

Description
Added minikube tunnel command to the tutorial. Without it, you can not access localhost:3000 because the service of type LoadBalancer is stuck in pending state.

@google-cla
Copy link

google-cla bot commented Mar 3, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@dapeleg-dn dapeleg-dn changed the title Update _index.md add minikube tunnel command docs: add minikube tunnel command in the tutorial Mar 3, 2023
@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

Added `minikube tunnel` command. Without it, you can not access `localhost:3000` because the service of type LoadBalancer is stuck in `pending` state.
@codecov
Copy link

codecov bot commented Mar 5, 2023

Codecov Report

Merging #8490 (5c48247) into main (290280e) will decrease coverage by 5.30%.
The diff coverage is 55.02%.

@@            Coverage Diff             @@
##             main    #8490      +/-   ##
==========================================
- Coverage   70.48%   65.18%   -5.30%     
==========================================
  Files         515      602      +87     
  Lines       23150    29912    +6762     
==========================================
+ Hits        16317    19498    +3181     
- Misses       5776     8942    +3166     
- Partials     1057     1472     +415     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 426 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gsquared94 gsquared94 merged commit e3b9e90 into GoogleContainerTools:main Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants