chore: change skaffold base image #8433
Conversation
|
Can you add some additional info as to how you manually verified the skaffold image still worked and had similar/identical functionality as it did prior? |
My bad! Was thinking this was tested somewhere in our ci, turns out not. Thank you for calling this out! I did some testing and then found some issues, added changes to fix those. |
Codecov Report
@@ Coverage Diff @@
## main #8433 +/- ##
==========================================
- Coverage 70.48% 65.21% -5.28%
==========================================
Files 515 603 +88
Lines 23150 29898 +6748
==========================================
+ Hits 16317 19497 +3180
- Misses 5776 8926 +3150
- Partials 1057 1475 +418
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
deploy/skaffold/Dockerfile.deps
Outdated
| @@ -151,7 +151,8 @@ RUN gcloud auth configure-docker && gcloud components install --quiet \ | |||
| log-streaming | |||
|
|
|||
| FROM runtime_deps | |||
| RUN apt-get update && apt-get install --no-install-recommends --no-install-suggests -y \ | |||
| DEBIAN_FRONTEND=noninteractive | |||
There was a problem hiding this comment.
Some package requires interaction after installation, set up this to skip it
| @@ -151,7 +151,8 @@ RUN gcloud auth configure-docker && gcloud components install --quiet \ | |||
| log-streaming | |||
|
|
|||
| FROM runtime_deps | |||
| RUN apt-get update && apt-get install --no-install-recommends --no-install-suggests -y \ | |||
| ENV DEBIAN_FRONTEND=noninteractive | |||
| RUN apt-get update && apt-get dist-upgrade -y && apt-get install --no-install-recommends --no-install-suggests -y \ | |||
There was a problem hiding this comment.
Can you add curl to the packages installed here? It seems this tool is not installed in Debian Bullseye but is in Ubuntu
This likely needs to be done in all of the Dockerfile.deps* files
There was a problem hiding this comment.
When this got partially reverted in #8460 it looks like this lost curl as we went from gcr.io/gcp-runtimes/ubuntu_20_0_4 which included curl to ubuntu:20.04 which doesn't.
Can curl be added back into the released Skaffold images please?
There was a problem hiding this comment.
@tomelliff thanks for flagging, this. I've created this issue #8668 tracking this and added it to Skaffold's next release -v2.4.0 which is targeting release for 4/17
* chore: Revert "chore: change skaffold base image (GoogleContainerTools#8433)" This reverts commit 6b3f673. * chore: update skaffold base image to ubuntu:20.04 * chore: add noninteractive (cherry picked from commit 9847653)
* chore: upgrade go in dockerfile (#8420) (cherry picked from commit 6289a4b) * chore: Update skaffold base image (#8460) * chore: Revert "chore: change skaffold base image (#8433)" This reverts commit 6b3f673. * chore: update skaffold base image to ubuntu:20.04 * chore: add noninteractive (cherry picked from commit 9847653) --------- Co-authored-by: ericzzzzzzz <[email protected]>
related: #8418
Fixes: #nnn
Related: Relevant tracking issues, for context
Merge before/after: Dependent or prerequisite PRs
Test Plan
docker build \ -f deploy/skaffold/Dockerfile.deps \ -t abc/build_deps:5b53a3d6c20eadaf870bb6f388c95107bbd731e8 \ .abc/build_deps:5b53a3d6c20eadaf870bb6f388c95107bbd731e8cp deploy/skaffold/Dockerfile .to copy dockerfile to working directorydocker build -t abc/builder:1234 --target builder .docker run --rm -v /var/run/docker.sock:/var/run/docker.sock abc/builder:1234 -e DOCKER_CONFIG=/root/.docker \ make integration-teststo run tests with the new image, we can exit container after seeing a few success.