Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add more detail to Cloud Run deployer page #8381

Merged
merged 4 commits into from
Feb 2, 2023
Merged

docs: add more detail to Cloud Run deployer page #8381

merged 4 commits into from
Feb 2, 2023

Conversation

renzodavid9
Copy link
Contributor

@renzodavid9 renzodavid9 commented Jan 30, 2023 •
edited
Loading

Fixes: #8320

Description
This PR adds more details for the Cloud Run deployer page.

@codecov
Copy link

codecov bot commented Jan 30, 2023 •
edited
Loading

Codecov Report

Merging #8381 (8c85c75) into main (290280e) will decrease coverage by 4.60%.
The diff coverage is 54.85%.

@@            Coverage Diff             @@
##             main    #8381      +/-   ##
==========================================
- Coverage   70.48%   65.88%   -4.60%     
==========================================
  Files         515      605      +90     
  Lines       23150    29819    +6669     
==========================================
+ Hits        16317    19646    +3329     
- Misses       5776     8698    +2922     
- Partials     1057     1475     +418
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 415 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@renzodavid9 renzodavid9 marked this pull request as ready for review January 31, 2023 17:07
@renzodavid9 renzodavid9 requested a review from a team January 31, 2023 17:07
@renzodavid9 renzodavid9 added the docs-modifications-v2 runs the docs v2 preview service on the given PR label Jan 31, 2023
@container-tools-bot
Copy link

Please visit http://34.28.55.185:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications-v2 runs the docs v2 preview service on the given PR label Jan 31, 2023
aaron-prindle
aaron-prindle reviewed Feb 2, 2023
View reviewed changes
docs-v2/content/en/docs/pipeline-stages/deployers/cloudrun.md Outdated
apiVersion: serving.knative.dev/v1
kind: Service
metadata:
name: cloud-run-service-name
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: cloud-run-service-name
name: cloud-run-service-name # this service will be created in Cloud Deploy via Skaffold

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change applied with the following text: this service will be created in Cloud Run via Skaffold: Changed Cloud Deploy to Cloud Run. Also I added the same comment for the Job.

aaron-prindle
aaron-prindle reviewed Feb 2, 2023
View reviewed changes
docs-v2/content/en/docs/pipeline-stages/deployers/cloudrun.md Outdated
apiVersion: run.googleapis.com/v1
kind: Job
metadata:
name: cloud-run-job-name
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might make sense to add a note/section explaining how Job is currently supported (can create Jobs but not trigger them)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. I already had a note about it, but I just changed it to make it look with the Notes format (as the card from the beginning of the page), let me know what do you think 😄

@aaron-prindle
Copy link
Contributor

aaron-prindle commented Feb 2, 2023 •
edited
Loading

Can you also change the maturity of Cloud Run to beta from alpha in this PR. This PR shows where this info is stored:
#8280

@renzodavid9 renzodavid9 added the docs-modifications-v2 runs the docs v2 preview service on the given PR label Feb 2, 2023
@container-tools-bot
Copy link

Please visit http://35.226.237.45:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications-v2 runs the docs v2 preview service on the given PR label Feb 2, 2023
@renzodavid9
Copy link
Contributor Author

Can you also change the maturity of Cloud Run to beta from alpha in this PR. This PR shows where this info is stored:
#8280

Done! Maturity changed

aaron-prindle
aaron-prindle approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aaron-prindle aaron-prindle merged commit 7a927d4 into GoogleContainerTools:main Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaron-prindle aaron-prindle aaron-prindle approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add/extend Skaffold Cloud Run Deployer docs to show a full sample app (vs just the schema)
3 participants
@renzodavid9 @container-tools-bot @aaron-prindle