Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ingore-path kaniko flag support #8340

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

simonoff
Copy link
Contributor

@simonoff simonoff commented Jan 19, 2023

Related: GoogleContainerTools/kaniko#2164

Description
For local development we are using skaffold. Also, as we are from Ukraine and there could be no elictricty or no internet we need to be able to working offline. For such purposes we have created a script which ups the kind cluster and we can continue working on.
On mac based systems we don't have any issues with kind and kaniko.
But unfortunately on linux machines we have a similar issue as in linked kaniko issue.
So we need to add such flag to kaniko.

User facing changes

Ability to add an ingore paths for kaniko.

@google-cla
Copy link

google-cla bot commented Jan 19, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Merging #8340 (34f9f5c) into main (290280e) will decrease coverage by 4.40%.
The diff coverage is 54.85%.

@@            Coverage Diff             @@
##             main    #8340      +/-   ##
==========================================
- Coverage   70.48%   66.09%   -4.40%     
==========================================
  Files         515      605      +90     
  Lines       23150    29658    +6508     
==========================================
+ Hits        16317    19601    +3284     
- Misses       5776     8588    +2812     
- Partials     1057     1469     +412     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 415 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaron-prindle aaron-prindle changed the title feat: add ingore-path kaniko flag support feat: add ignore-path kaniko flag support Jan 19, 2023
@aaron-prindle aaron-prindle changed the title feat: add ignore-path kaniko flag support feat: add ingore-path kaniko flag support Jan 19, 2023
Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR here @simonoff!

@aaron-prindle aaron-prindle merged commit 7d346f5 into GoogleContainerTools:main Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants