-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add proper artifactOverrides->setValueTemplates conversion when upgrading from v2beta29 #8335
Merged
aaron-prindle
merged 1 commit into
GoogleContainerTools:main
from
aaron-prindle:fix-8321
Jan 20, 2023
Merged
fix: add proper artifactOverrides->setValueTemplates conversion when upgrading from v2beta29 #8335
aaron-prindle
merged 1 commit into
GoogleContainerTools:main
from
aaron-prindle:fix-8321
Jan 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-prindle
force-pushed
the
fix-8321
branch
3 times, most recently
from
January 19, 2023 06:36
19d6edc
to
c737aa6
Compare
Codecov Report
@@ Coverage Diff @@
## main #8335 +/- ##
==========================================
- Coverage 70.48% 65.95% -4.54%
==========================================
Files 515 605 +90
Lines 23150 29736 +6586
==========================================
+ Hits 16317 19612 +3295
- Misses 5776 8651 +2875
- Partials 1057 1473 +416
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
aaron-prindle
force-pushed
the
fix-8321
branch
2 times, most recently
from
January 19, 2023 07:06
da93f68
to
4477cf1
Compare
renzodavid9
reviewed
Jan 19, 2023
renzodavid9
reviewed
Jan 19, 2023
gsquared94
reviewed
Jan 19, 2023
aaron-prindle
force-pushed
the
fix-8321
branch
5 times, most recently
from
January 19, 2023 20:55
1765174
to
b0e48bf
Compare
PTAL, addressed comments |
renzodavid9
approved these changes
Jan 19, 2023
…upgrading from v2beta29
aaron-prindle
force-pushed
the
fix-8321
branch
from
January 19, 2023 23:45
b0e48bf
to
dd0110b
Compare
gsquared94
approved these changes
Jan 19, 2023
aaron-prindle
added a commit
to aaron-prindle/skaffold
that referenced
this pull request
Mar 1, 2023
…upgrading from v2beta29 (GoogleContainerTools#8335) (cherry picked from commit 6e59fdc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8321