Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add proper artifactOverrides->setValueTemplates conversion when upgrading from v2beta29 #8335

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

aaron-prindle
Copy link
Contributor

fixes #8321

@aaron-prindle aaron-prindle force-pushed the fix-8321 branch 3 times, most recently from 19d6edc to c737aa6 Compare January 19, 2023 06:36
@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Merging #8335 (dd0110b) into main (290280e) will decrease coverage by 4.54%.
The diff coverage is 54.85%.

@@            Coverage Diff             @@
##             main    #8335      +/-   ##
==========================================
- Coverage   70.48%   65.95%   -4.54%     
==========================================
  Files         515      605      +90     
  Lines       23150    29736    +6586     
==========================================
+ Hits        16317    19612    +3295     
- Misses       5776     8651    +2875     
- Partials     1057     1473     +416     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 415 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaron-prindle aaron-prindle force-pushed the fix-8321 branch 2 times, most recently from da93f68 to 4477cf1 Compare January 19, 2023 07:06
@aaron-prindle aaron-prindle force-pushed the fix-8321 branch 5 times, most recently from 1765174 to b0e48bf Compare January 19, 2023 20:55
@aaron-prindle
Copy link
Contributor Author

PTAL, addressed comments

@aaron-prindle aaron-prindle merged commit 6e59fdc into GoogleContainerTools:main Jan 20, 2023
aaron-prindle added a commit to aaron-prindle/skaffold that referenced this pull request Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[regression] Skaffold v1 -> v2 helm artifactsOverride usage not automatically updated -> failures
3 participants