Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expand namespace with env variables #8222

Merged
merged 2 commits into from
Dec 13, 2022

Conversation

renzodavid9
Copy link
Contributor

@renzodavid9 renzodavid9 commented Dec 12, 2022

Fixes: #8183

Description
Now, before returning the namespace from the runcontext, we replace the env variables if any is present.

@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Merging #8222 (d6efa0e) into main (290280e) will decrease coverage by 4.35%.
The diff coverage is 53.26%.

@@            Coverage Diff             @@
##             main    #8222      +/-   ##
==========================================
- Coverage   70.48%   66.12%   -4.36%     
==========================================
  Files         515      601      +86     
  Lines       23150    29483    +6333     
==========================================
+ Hits        16317    19497    +3180     
- Misses       5776     8527    +2751     
- Partials     1057     1459     +402     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/test.go 44.44% <0.00%> (ø)
cmd/skaffold/app/exitcode.go 100.00% <ø> (+6.66%) ⬆️
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/render.go 35.48% <18.18%> (-5.90%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/run.go 64.28% <33.33%> (-9.63%) ⬇️
... and 396 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@renzodavid9 renzodavid9 added kokoro:run runs the kokoro jobs on a PR kokoro:force-run forces a kokoro re-run on a PR and removed kokoro:run runs the kokoro jobs on a PR kokoro:force-run forces a kokoro re-run on a PR labels Dec 13, 2022
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Dec 13, 2022
@renzodavid9 renzodavid9 added the kokoro:force-run forces a kokoro re-run on a PR label Dec 13, 2022
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Dec 13, 2022
@renzodavid9 renzodavid9 marked this pull request as ready for review December 13, 2022 20:39
@renzodavid9 renzodavid9 requested review from aaron-prindle and a team December 13, 2022 20:39
Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!! LGTM

@aaron-prindle aaron-prindle merged commit ee13c6f into GoogleContainerTools:main Dec 13, 2022
aaron-prindle pushed a commit to aaron-prindle/skaffold that referenced this pull request Dec 20, 2022
* fix: expand namespace with env variables

* test: integration test for defaultNamespace config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skaffold not properly replacing helm env variables under defaultNamespace (at least HOST variable)
3 participants