Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add unique tag to test image to avoid collisions with other tests #8087

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

renzodavid9
Copy link
Contributor

Fixes: #8025

Description
Add unique tag to test image to avoid collision with other tests running at the same time using the same image.

@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Merging #8087 (a34604b) into main (290280e) will decrease coverage by 3.99%.
The diff coverage is 53.61%.

@@            Coverage Diff             @@
##             main    #8087      +/-   ##
==========================================
- Coverage   70.48%   66.48%   -4.00%     
==========================================
  Files         515      597      +82     
  Lines       23150    29172    +6022     
==========================================
+ Hits        16317    19395    +3078     
- Misses       5776     8338    +2562     
- Partials     1057     1439     +382     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/test.go 44.44% <0.00%> (ø)
cmd/skaffold/app/exitcode.go 100.00% <ø> (+6.66%) ⬆️
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/render.go 35.48% <18.18%> (-5.90%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/run.go 64.28% <33.33%> (-9.63%) ⬇️
cmd/skaffold/app/cmd/fix.go 56.41% <37.50%> (-20.07%) ⬇️
... and 394 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@renzodavid9 renzodavid9 marked this pull request as ready for review November 14, 2022 19:51
@renzodavid9 renzodavid9 requested review from a team and gsquared94 and removed request for a team November 14, 2022 19:51
@ericzzzzzzz ericzzzzzzz merged commit f96d6c2 into GoogleContainerTools:main Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[flake] TestRunGCPOnly/jib_gradle_in_googlecloudbuild
2 participants