-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sec): upgrade runc version v1.0.2 -> v1.1.2 #8050
fix(sec): upgrade runc version v1.0.2 -> v1.1.2 #8050
Conversation
Codecov Report
@@ Coverage Diff @@
## main #8050 +/- ##
==========================================
- Coverage 70.48% 66.49% -3.99%
==========================================
Files 515 597 +82
Lines 23150 29146 +5996
==========================================
+ Hits 16317 19382 +3065
- Misses 5776 8327 +2551
- Partials 1057 1437 +380
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
a04c32d
to
26ef356
Compare
go.mod
Outdated
@@ -95,7 +95,7 @@ require ( | |||
google.golang.org/grpc v1.49.0 | |||
google.golang.org/protobuf v1.28.1 | |||
gopkg.in/yaml.v2 v2.4.0 | |||
gopkg.in/yaml.v3 v3.0.0-20210107192922-496545a6307b | |||
gopkg.in/yaml.v3 v3.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember there was a reason we were pinned to a specific version of yaml.v3
although I don't recall what it was.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aah here it is:
Lines 11 to 14 in 9802b0e
// pin yamlv3 to parent of https://github.com/go-yaml/yaml/commit/ae27a744346343ea814bd6f3bdd41d8669b172d0 | |
// Avoid indenting sequences. | |
gopkg.in/yaml.v3 => gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I can hold off on this then and try to understand more why we pin atm. There was a security bot that suggested this change which is the context here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed the PR to only update runc
due to comments here
Changed this PR to only update runc |
e544649
to
b5d719b
Compare
No description provided.