-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump skaffold schema version to v4beta1 #8034
Merged
aaron-prindle
merged 1 commit into
GoogleContainerTools:main
from
aaron-prindle:create-v4beta1-schema
Nov 4, 2022
Merged
chore: bump skaffold schema version to v4beta1 #8034
aaron-prindle
merged 1 commit into
GoogleContainerTools:main
from
aaron-prindle:create-v4beta1-schema
Nov 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-prindle
force-pushed
the
create-v4beta1-schema
branch
3 times, most recently
from
November 3, 2022 20:40
64b9254
to
701ca79
Compare
Codecov Report
@@ Coverage Diff @@
## main #8034 +/- ##
==========================================
- Coverage 70.48% 66.61% -3.88%
==========================================
Files 515 598 +83
Lines 23150 28984 +5834
==========================================
+ Hits 16317 19307 +2990
- Misses 5776 8250 +2474
- Partials 1057 1427 +370
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
gsquared94
reviewed
Nov 3, 2022
aaron-prindle
force-pushed
the
create-v4beta1-schema
branch
from
November 3, 2022 22:44
701ca79
to
036086e
Compare
gsquared94
approved these changes
Nov 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
aaron-prindle
force-pushed
the
create-v4beta1-schema
branch
3 times, most recently
from
November 4, 2022 00:40
0a3c09d
to
2541fb1
Compare
aaron-prindle
force-pushed
the
create-v4beta1-schema
branch
from
November 4, 2022 00:56
2541fb1
to
aae85f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5132 and #7990