Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add description to StatusCheck TaskEvent #8017

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

aaron-prindle
Copy link
Contributor

fixes #8016

Similar to the fix for #7937 (same issue just with StatusCheck TaskEvent)

@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Merging #8017 (b3693a8) into main (290280e) will decrease coverage by 3.77%.
The diff coverage is 54.09%.

@@            Coverage Diff             @@
##             main    #8017      +/-   ##
==========================================
- Coverage   70.48%   66.70%   -3.78%     
==========================================
  Files         515      596      +81     
  Lines       23150    28897    +5747     
==========================================
+ Hits        16317    19277    +2960     
- Misses       5776     8196    +2420     
- Partials     1057     1424     +367     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/test.go 44.44% <0.00%> (ø)
cmd/skaffold/app/exitcode.go 100.00% <ø> (+6.66%) ⬆️
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/render.go 35.48% <18.18%> (-5.90%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/run.go 64.28% <33.33%> (-9.63%) ⬇️
cmd/skaffold/app/cmd/fix.go 56.41% <37.50%> (-20.07%) ⬇️
... and 390 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaron-prindle aaron-prindle merged commit 997edfa into GoogleContainerTools:main Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloud Code log viewer currently shows empty message for StatusCheck stage
2 participants