Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add an example for snapshot.ubuntu.com #47

Merged
merged 3 commits into from
May 17, 2024
Merged

Conversation

thesayyn
Copy link
Collaborator

@thesayyn thesayyn commented May 17, 2024

This just works 'trademark'!

Please only review the first commit, as the two following commits are consequential changes i had to make.

PS: don't squash when merging.

@thesayyn thesayyn merged commit 4775e35 into main May 17, 2024
7 checks passed
jjmaestro added a commit to jjmaestro/rules_distroless that referenced this pull request Sep 19, 2024
It seemed like 75afff9 in GoogleContainerTools#47 added the new locks but as new files, that
is, the old ones were left behind.
jjmaestro added a commit to jjmaestro/rules_distroless that referenced this pull request Sep 22, 2024
It seemed like 75afff9 in GoogleContainerTools#47 added the new locks but as new files, that
is, the old ones were left behind.
thesayyn pushed a commit that referenced this pull request Oct 28, 2024
…87)

* fix: MODULE.bazel.lock conflicts

See bazelbuild/bazel#20369

While working on refactoring, I kept hitting rebase conflicts due to
issues with the MODULE lock. I guess it's because the Bazel version in
e2e tests is much lower than the current one with the fix (7.2) but
still, I don't think it adds much to have the lock in e2e testing.

* fix: repo name in copy.sh script

PR #73 added the `_resolve` and this breaks the buildozer fix / autofix

* fix: remove dead locks

It seemed like 75afff9 in #47 added the new locks but as new files, that
is, the old ones were left behind.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants