Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix checkPushPermissions by --insecure #737

Closed
wants to merge 13 commits into from
Closed

fix checkPushPermissions by --insecure #737

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
af0f504
Update push.go
cn-sunletian May 31, 2019
c230492
Update push.go
cn-sunletian May 31, 2019
dfa2d69
Update push.go
cn-sunletian May 31, 2019
9af3795
Update push.go
cn-sunletian May 31, 2019
0c4d056
Update push.go
cn-sunletian May 31, 2019
c326ae8
Update push.go
cn-sunletian May 31, 2019
96a3739
Update push.go
cn-sunletian May 31, 2019
25995ea
Update push.go
cn-sunletian May 31, 2019
0383cc7
Merge remote-tracking branch 'upstream/master'
cn-sunletian Aug 9, 2019
08b3097
fix InsecureRegistry old function
cn-sunletian Aug 10, 2019
e802514
if opts is insecure , checkPushPermissions add new insecure registry
cn-sunletian Aug 21, 2019
bb579de
make code cleaner
cn-sunletian Sep 11, 2019
b074ad0
Merge branch 'master' of https://github.com/GoogleContainerTools/kaniko
cn-sunletian Sep 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pkg/executor/push.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,13 @@ func CheckPushPermissions(opts *config.KanikoOptions) error {
checked := map[string]bool{}
for _, destination := range opts.Destinations {
destRef, err := name.NewTag(destination, name.WeakValidation)
if opts.Insecure || opts.InsecureRegistries.Contains(destination) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shd this be && instead of ||

newReg, err := name.NewRegistry(destination, name.WeakValidation, name.Insecure)
if err != nil {
return errors.Wrap(err, "getting new insecure registry")
}
destRef.Repository.Registry = newReg
}
if err != nil {
return errors.Wrap(err, "getting tag for destination")
}
Expand Down