Fix checking push permission without skipping tls on configured (#628) #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imjasonh
approved these changes
Apr 3, 2019
| if err := remote.CheckPushPermission(destRef, creds.GetKeychain(), http.DefaultTransport); err != nil { | ||
|
|
||
| // Create a transport to set our user-agent. | ||
| tr := http.DefaultTransport |
There was a problem hiding this comment.
Should there be (is there already?) some kind of GetTransport() method that does this in a shared location, sort of like how creds.GetKeychain() does? I'm not familiar with all of the available opts, and even if I were, if a new opt was added that configured HTTP requests like this, it'd be nice to have that applied in one common location.
I don't think it should necessarily block this PR, but it'd be nice to get feedback from someone more familiar with kaniko.
dbolshak
referenced
this pull request
Apr 3, 2019
* Check push permissions before building images * Fix doc comment * improve error messages
|
IMO it would be better to extract this into a function. Did that in #663. |
|
@zhleonix would like to rebase this ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking push permission, the skip-tls-verify options are not used, which causes failed operation on our private registry without importing root cert into the kaniko image.:
error checking push permissions -- make sure you entered the correct tag name, and that you are authenticated correctly, and try again: checking push permission for "private.repo/test/kaniko_demo:latest": Get https://private.repo/v2/: x509: certificate signed by unknown authority
A fix is required to add skipTlsVerify into httpTransport used in CheckPushPermissions.