Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for no push environment variable #2983

Merged
merged 4 commits into from
Feb 23, 2024
Merged

feat: add support for no push environment variable #2983

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f120908
feat: add support for no push environment variable
sachasmart Feb 1, 2024
677ee0c
Update to Readme
sachasmart Feb 20, 2024
a05b42e
feat: add support for no push environment variable
sachasmart Feb 20, 2024
09d8955
feat: add support for no push environment variable
sachasmart Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions cmd/executor/cmd/root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import (
"os/exec"
"path/filepath"
"regexp"
"strconv"
"strings"
"time"

Expand Down Expand Up @@ -71,6 +72,15 @@ func validateFlags() {
opts.RegistryMirrors.Set(val)
}

// Allow setting --no-push using an environment variable.
if val, ok := os.LookupEnv("KANIKO_NO_PUSH"); ok {
valBoolean, err := strconv.ParseBool(val)
if err != nil {
errors.New("invalid value (true/false) for KANIKO_NO_PUSH environment variable")
}
opts.NoPush = valBoolean
}

// Allow setting --registry-maps using an environment variable.
if val, ok := os.LookupEnv("KANIKO_REGISTRY_MAP"); ok {
opts.RegistryMaps.Set(val)
Expand Down