Fix resolving arguments over multi-stage build #1928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabyx
force-pushed
the
bugfix/fix-resolving-stage-arguments
branch
2 times, most recently
from
23c348a to
8126c2f
Compare
gabyx
changed the title
gabyx
force-pushed
the
bugfix/fix-resolving-stage-arguments
branch
6 times, most recently
from
1777c2b to
5f79dae
Compare
gabyx
changed the title
|
So good to see that fixed. Please review it guys! |
gabyx
commented
Feb 8, 2022
gabyx
force-pushed
the
bugfix/fix-resolving-stage-arguments
branch
from
5f79dae to
b08e907
Compare
|
Test report wrong output (PASSED, instead its failed!!). Please fix this. Tests actually are now successful, No Diff. |
- Building multi-stage Dockerfiles did not correctly resolve ARG commands over different stages. Now, each stage depends on the build arguments set by the stage before. Closes: GoogleContainerTools#1911
gabyx
force-pushed
the
bugfix/fix-resolving-stage-arguments
branch
from
b08e907 to
3bed0f8
Compare
imjasonh
approved these changes
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1911
Description
Arguments are not correctly resolved over multi-stage builds.
See test.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes
Describe any changes here so maintainer can include it in the release notes, or delete this block.