Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save snaphots to tmp dir #1662

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

pbarker
Copy link
Contributor

@pbarker pbarker commented Jun 2, 2021

Description

Saves snapshots to a temp directory so that they can be mounted in environments where they are too large for the container storage. Currently they cannot be mounted because they are saved in the same directory as the binaries

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

Snapshots now saved to tmp dir

@google-cla
Copy link

google-cla bot commented Jun 2, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no CLA not signed by all commit authors label Jun 2, 2021
@pbarker pbarker force-pushed the configurable-snapshots branch from 74a3ddf to ecd7bc6 Compare June 3, 2021 20:08
@google-cla google-cla bot added cla: yes CLA signed by all commit authors and removed cla: no CLA not signed by all commit authors labels Jun 3, 2021
@tejal29
Copy link
Contributor

tejal29 commented Jun 4, 2021

@pbarker unit tests are failing. Let me know if you need help fixing these.

@tejal29 tejal29 merged commit 754253d into GoogleContainerTools:master Jun 14, 2021
tejal29 added a commit that referenced this pull request Jun 14, 2021
tejal29 added a commit that referenced this pull request Jun 14, 2021
@tejal29
Copy link
Contributor

tejal29 commented Jun 14, 2021

accidentally merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA signed by all commit authors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants