Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Buildconfig object to detect if current test run is on travis #1051

Closed
wants to merge 1 commit into from
Closed

Add Buildconfig object to detect if current test run is on travis #1051

wants to merge 1 commit into from

Conversation

tejal29
Copy link
Contributor

@tejal29 tejal29 commented Feb 13, 2020

Relates to #1050
In this PR

  1. Add a new buildConfig to integrationTestConfig.
  2. Move initIntegrationTestConfig to integration/config.go
  3. Change all errors beginning with capital letter to small letter

@googlebot googlebot added the cla: yes CLA signed by all commit authors label Feb 13, 2020
@tejal29 tejal29 force-pushed the prepare_for_benchmark branch from 4c542eb to 751450d Compare February 13, 2020 18:52
@tejal29 tejal29 requested review from samos123 and cvgw February 13, 2020 18:53
@tejal29
Copy link
Contributor Author

tejal29 commented May 20, 2020

no needed now.

@tejal29 tejal29 closed this May 20, 2020
@tejal29 tejal29 reopened this May 20, 2020
@tejal29 tejal29 closed this May 20, 2020
@tejal29 tejal29 deleted the prepare_for_benchmark branch April 26, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samos123 samos123 Awaiting requested review from samos123

@cvgw cvgw Awaiting requested review from cvgw

Assignees
No one assigned
Labels
cla: yes CLA signed by all commit authors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tejal29 @googlebot