Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Draft] Do not apply the dockerignore patterns between intermediate stages #1022

Closed
wants to merge 4 commits into from
Closed

[Draft] Do not apply the dockerignore patterns between intermediate stages #1022

wants to merge 4 commits into from

Conversation

tejal29
Copy link
Contributor

@tejal29 tejal29 commented Feb 4, 2020 •
edited
Loading

Fixes #595

Only apply .dockerignore file for resolving sources

  1. For Add command
  2. For Copy command if there is no from

Also some performance cleanup.

TODO: cleanup copyDir and copyFile

@googlebot googlebot added the cla: yes CLA signed by all commit authors label Feb 4, 2020
@tejal29 tejal29 changed the title [DRAFT] Proof of concept. Do not apply the dockerignore patterns between intermediate stages Do not apply the dockerignore patterns between intermediate stages Feb 4, 2020
@tejal29 tejal29 changed the title Do not apply the dockerignore patterns between intermediate stages [Draft] Do not apply the dockerignore patterns between intermediate stages Feb 4, 2020
@tejal29 tejal29 closed this Feb 4, 2020
@tejal29 tejal29 deleted the respectDockerIgnore branch February 4, 2020 22:19
@tejal29 tejal29 restored the respectDockerIgnore branch May 4, 2020 18:22
@tejal29 tejal29 reopened this May 4, 2020
@tejal29
Copy link
Contributor Author

tejal29 commented May 20, 2020

this was replaced by #1234

@tejal29 tejal29 closed this May 20, 2020
@tejal29 tejal29 deleted the respectDockerIgnore branch April 26, 2021 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes CLA signed by all commit authors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The .dockerignore file also matches between stages
2 participants
@tejal29 @googlebot