-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CHANGELOG and integration tests for extra directories filtering #3176
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3176 +/- ##
=========================================
Coverage 71.18% 71.18%
Complexity 2331 2331
=========================================
Files 279 279
Lines 9846 9846
Branches 990 990
=========================================
Hits 7009 7009
Misses 2491 2491
Partials 346 346
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add a test for maven as well?
...rc/integration-test/java/com/google/cloud/tools/jib/gradle/SingleProjectIntegrationTest.java
Show resolved
Hide resolved
Added a Maven integration test too. I also realized a minor issue with the filtering. Will fix it in a follow-up PR. |
For #2564 and #3164.