Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CHANGELOG and integration tests for extra directories filtering #3176

Merged
merged 4 commits into from
Apr 1, 2021

Conversation

chanseokoh
Copy link
Member

@chanseokoh chanseokoh commented Mar 31, 2021

For #2564 and #3164.

@google-cla google-cla bot added the cla: yes label Mar 31, 2021
@codecov
Copy link

codecov bot commented Mar 31, 2021

Codecov Report

Merging #3176 (9fb2f85) into master (b286cca) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3176   +/-   ##
=========================================
  Coverage     71.18%   71.18%           
  Complexity     2331     2331           
=========================================
  Files           279      279           
  Lines          9846     9846           
  Branches        990      990           
=========================================
  Hits           7009     7009           
  Misses         2491     2491           
  Partials        346      346           
Impacted Files Coverage Δ Complexity Δ
...jib/plugins/common/JavaContainerBuilderHelper.java 95.31% <100.00%> (ø) 21.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b286cca...9fb2f85. Read the comment docs.

Copy link
Contributor

@mpeddada1 mpeddada1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a test for maven as well?

@chanseokoh chanseokoh marked this pull request as ready for review April 1, 2021 15:33
@chanseokoh
Copy link
Member Author

Added a Maven integration test too.

I also realized a minor issue with the filtering. Will fix it in a follow-up PR.

@chanseokoh chanseokoh merged commit 6bce5ab into master Apr 1, 2021
@chanseokoh chanseokoh deleted the extra-dirs-integ-tests-changelog branch April 1, 2021 16:02
@chanseokoh chanseokoh mentioned this pull request Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants