Fix Datastream private connection resource destruction #2659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sagi Yosefia <[email protected]> [upstream:7230c2123c05b14f8f9d5e3029d9d4d955aafa66] Signed-off-by: Modular Magician <[email protected]>
modular-magician
requested review from
iyabchen
and removed request for
a team
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
modular-magician
merged commit e99f784
into
GoogleCloudPlatform:main
5 of 6 checks passed
modular-magician
deleted the
downstream-pr-7230c2123c05b14f8f9d5e3029d9d4d955aafa66
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Datastream private connection resource destruction. The current private connection resource deletion fails as a result of sub resource existence.
This fix will always force the resource deletion, as the sub resources deletion is taking care the the API anyway.
Fixes hashicorp/terraform-provider-google#17290
hashicorp/terraform-provider-google#13054
Derived from GoogleCloudPlatform/magic-modules#11394