Allowed modifying request headers via pre_create, pre_read, pre_update, or pre_delete custom code #2148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e, or pre_delete custom code (#10405) [upstream:ffaae417cb248eaae954f16ed4c55700efe6577e] Signed-off-by: Modular Magician <[email protected]>
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
modular-magician
deleted the
downstream-pr-ffaae417cb248eaae954f16ed4c55700efe6577e
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved hashicorp/terraform-provider-google#16331.
The specific resource issue this was blocking (hashicorp/terraform-provider-google#15550) was resolved separately so no changes are needed there.
Given we don't have a clear idea of what features we might need to support in the future, and this does not currently seem to be a common use case, I don't want to implement any kind of special MM field at this time; however, this change would be necessary for any changes to MM fields in the future as well.
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#10405