Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fields pathTemplateMatch and pathTemplateRewrite to resource google_compute_region_url_map #2051

Conversation

modular-magician
Copy link
Collaborator

Add the pathTemplateMatch and pathTemplateRewrite fields to Region URL Map resource.

Fixes hashicorp/terraform-provider-google#17545

I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added field `path_template_match` to resource `google_compute_region_url_map`
compute: added field `path_template_rewrite` to resource `google_compute_region_url_map`

Derived from GoogleCloudPlatform/magic-modules#10157

…le_compute_region_url_map (#10157)

[upstream:48d346d562b56f53668e2b34e1eab4a536ba097a]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner March 13, 2024 13:54
@modular-magician modular-magician requested review from iyabchen and removed request for a team March 13, 2024 13:54
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@modular-magician modular-magician merged commit b3e2812 into GoogleCloudPlatform:main Mar 13, 2024
4 of 5 checks passed
@modular-magician modular-magician deleted the downstream-pr-48d346d562b56f53668e2b34e1eab4a536ba097a branch November 18, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform support for Wildcard Path Matching and Rewrites of Regional HTTP(S) Load Balancers
1 participant