Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry delete network step while creating a google project. #1991

Conversation

modular-magician
Copy link
Collaborator

compute.googleapis.com API must be enabled to delete the network related to the newly created project.

We first enable the compute API. But this takes some time to propagate to all the systems. Hence, delete network API sometimes returns 403- compute api is not enabled error.

To mitigate this issue, we will wait for 10s and retry the delete network step when there is 403 error.

Release Note Template for Downstream PRs (will be copied)

resourcemanager: added a retry to deleting the default network when `auto_create_network` is false in `google_project`

Derived from GoogleCloudPlatform/magic-modules#10046

[upstream:7faaacc8f1d429d6d0d6317ba98e962bf9bd1ae4]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner February 26, 2024 20:55
@modular-magician modular-magician requested review from iyabchen and removed request for a team February 26, 2024 20:55
@modular-magician modular-magician merged commit 4629e8e into GoogleCloudPlatform:main Feb 26, 2024
5 checks passed
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@modular-magician modular-magician deleted the downstream-pr-7faaacc8f1d429d6d0d6317ba98e962bf9bd1ae4 branch November 18, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant