Add Oracle support to DBMS #1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[upstream:e42af6b9a19a00d387c3dbbb340bd33630cd94a3] Signed-off-by: Modular Magician <[email protected]>
modular-magician
deleted the
downstream-pr-e42af6b9a19a00d387c3dbbb340bd33630cd94a3
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes hashicorp/terraform-provider-google#15647
Adds support for Oracle profiles in DBMS, additionally adds missing static/private connectivity support to postgres profiles (that was also included with the Oracle profiles).
Two quirks happening here:
We can not actually create an oracle DB for testing (so the created tests fail, as it actually tests a connection to the supplied db)
The data stream private connection is actually a more generic resource than just data stream (reaches the same downstream URI with the same structure), so it would work for that oracle test... in theory
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#9114